Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use chrome custom tabs for auth #89

Merged
merged 3 commits into from
Sep 28, 2023
Merged

feat: use chrome custom tabs for auth #89

merged 3 commits into from
Sep 28, 2023

Conversation

dom-murray
Copy link
Collaborator

  • Chrome custom tabs uses AndroidX so the game's gradle.properties needs to enable it
  • Create ImmutableAndroid.androidlib in Runtime/Assets which contains the logic to launch a chrome custom tab
  • Updated PassportImpl to use Android launchUrl instead of Unity's Application.OpenUrl
  • When building for Android the platform is considered to be UNITY_EDITOR_OSX. This was breaking the build as we have it in locations for iOS logic. Fixed this by removing those checks.

@dom-murray dom-murray force-pushed the feat/dx-2365-chrome-custom-tabs branch 2 times, most recently from 3bc6610 to 38510f3 Compare September 28, 2023 02:41
@dom-murray dom-murray force-pushed the feat/dx-2365-chrome-custom-tabs branch from 38510f3 to 876dd38 Compare September 28, 2023 02:49
@dom-murray dom-murray merged commit 6c5fa37 into main Sep 28, 2023
5 checks passed
@dom-murray dom-murray deleted the feat/dx-2365-chrome-custom-tabs branch September 28, 2023 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nattb8 nattb8 nattb8 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dom-murray @nattb8